Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamp animation time to available range #1504

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Jun 30, 2024

fixes #1501, also makes the message slightly less verbose

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (b700c44) to head (e3f54c5).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
- Coverage   96.78%   96.77%   -0.02%     
==========================================
  Files         105      105              
  Lines        7831     7834       +3     
==========================================
+ Hits         7579     7581       +2     
- Misses        252      253       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing improvements needed

@mwestphal mwestphal merged commit c83af74 into f3d-app:master Jul 5, 2024
41 checks passed
@snoyer snoyer deleted the clamp-animation-time branch July 5, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid failing when provided animation time is outside of time range
2 participants