Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 repeat VoiceOver interrupted announcement 🚧 #5

Closed
wants to merge 4 commits into from

Conversation

fabOnReact
Copy link
Owner

@fabOnReact fabOnReact commented Dec 1, 2022

Draft implementation to test functionality with react-native
The retry logic should move to iOS objc as done with https://github.com/fabriziobertoglio1987/react-native/blob/e0eaa3c05fb5e10e7fcb25fe74a11006f80c5a30/React/CoreModules/RCTAccessibilityManager.mm#L105-L118

This solution is included to showcase an alternative solution to setTimeout:

  • trigger accessibility event on iOS
  • iOS callback detects failure to announce (system stops announcement) and retries

The JavaScript iOS APIs are already available in react-native, the first draft solution was implemented in JavaScript as Proof of Concept. The alternative is using dispatch_after.

Related facebook#34969

@fabOnReact fabOnReact changed the title Announcements queue retry VoiceOver failing announcement Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Fails
🚫

❗ Base Branch - The base branch for this PR is something other than main or a -stable branch. Are you sure you want to target something other than the main branch?

🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against db6f1de

Repository owner deleted a comment from github-actions bot Dec 1, 2022
Repository owner deleted a comment from github-actions bot Dec 1, 2022
Repository owner deleted a comment from github-actions bot Dec 1, 2022
Repository owner deleted a comment from github-actions bot Dec 1, 2022
Repository owner deleted a comment from github-actions bot Dec 1, 2022
Repository owner deleted a comment from github-actions bot Dec 1, 2022
Repository owner deleted a comment from github-actions bot Dec 1, 2022
@fabOnReact fabOnReact changed the title retry VoiceOver failing announcement 🚧 retry VoiceOver failing announcement 🚧 Dec 1, 2022
@fabOnReact fabOnReact changed the title 🚧 retry VoiceOver failing announcement 🚧 🚧 repeat VoiceOver interrupted announcement 🚧 Dec 2, 2022
@fabOnReact fabOnReact closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant