Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Lerna NPM package management. #91

Merged
merged 4 commits into from
Oct 15, 2019
Merged

Prepare for Lerna NPM package management. #91

merged 4 commits into from
Oct 15, 2019

Conversation

jrwats
Copy link
Contributor

@jrwats jrwats commented Oct 15, 2019

@public
#90 Any published NPM module will now live under the packages per Lerna best practices. This is not strictly required, but makes our top-level repo slightly more sane, so we might as well abide by the community pattern.

In the process, I'm fixing the paths in yarn scripts in .*demo-apps referencing ../transform here also.

Ultimately we're doing:

transform/* => packages/*
fbt-runtime/* => packages/fbt/*
fb-tiger-hash => packages/fb-tiger-hash

Test Plan:

yarn
cd demo-app
yarn manifest
yarn collect-fbts
yarn translate-fbts
yarn test
yarn start

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 15, 2019
@jrwats jrwats changed the title [i18n][js][OSS] Prepare for Lerna NPM package management. Prepare for Lerna NPM package management. Oct 15, 2019
@kayhadrin kayhadrin self-requested a review October 15, 2019 21:08
@jrwats jrwats merged commit 9963128 into master Oct 15, 2019
@jrwats jrwats deleted the prep4lerna branch October 15, 2019 23:11
yarn.lock Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants