-
Notifications
You must be signed in to change notification settings - Fork 613
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prepare HttpStore for separate configurability for reads and writes
Summary: Up until now, `HttpStore` has consumed a config where the writes and reads to and from a remote storage API have been using the same setup. We internally need to migrate from the buck1 remote cache to another provider, and Manifold is the easiest option since it provides an HTTP API. However, unlike the special buckcache endpoint, reads and writes to this API need somewhat different setup. I'm introducing the Manifold configuration later in this stack, but this diff is simply refactoring HttpStore so that it optionally allows for separate configs for reads and writes. Aside from that, it also adds the ability to append headers and URL query parameters. These are both needed for Manifold as well. All changes have been made in a backwards compatible setup, where we still accept a singular configuration for more homogeneous APIs out there. Reviewed By: robhogan Differential Revision: D52917202 fbshipit-source-id: 376a1604c1a7cff75ba297430fee231f9d569f2a
- Loading branch information
1 parent
96e99fb
commit 3e647a6
Showing
1 changed file
with
68 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters