Ignore errors in unreachable modules #1164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52457312 |
|
This pull request was exported from Phabricator. Differential Revision: D52457312 |
Summary: Currently, if Metro encounters an error resolving a dependency or transforming a module that is present in the graph at the time the error is introduced, it will return the error to the client *and continue to do so, even after the bad dependency is subsequently made unreachable by another change*. This is "fixed" by a full refresh or Metro restart, because a new traversal would not encounter the error, and is therefore a correctness bug. This diff fixes the bug by: - Collecting, instead of immediately throwing on, transform and resolution errors during `buildSubgraph` (prior to any state modification). - If there are errors, take a snapshot of all of the modified modules at the base state. - Commit *removals only*, skipping modified modules with errors, and collect cycles (the "subtractive pass") - this should never fail. - Try to commit new and modified dependencies starting from the modified modules still present in the graph (the "additive pass"). Any error caught here corresponds to a reachable error the user must action. - On catching an error, commit the base state we captured earlier, rolling the graph back, and re-throw the error. Changelog: ``` **[Fix]**: Ignore errors in unreachable modules during incremental builds. ``` Reviewed By: motiz88 Differential Revision: D52457312
robhogan
force-pushed
the
export-D52457312
branch
from
2aaa50f
to
4be4a30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52457312 |
|
This pull request has been merged in 698b13e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, if Metro encounters an error resolving a dependency or transforming a module that is present in the graph at the time the error is introduced, it will return the error to the client and continue to do so, even after the bad dependency is subsequently made unreachable by another change.
This is "fixed" by a full refresh or Metro restart, because a new traversal would not encounter the error, and is therefore a correctness bug.
This diff fixes the bug by:
buildSubgraph(prior to any state modification).Changelog:
Reviewed By: motiz88
Differential Revision: D52457312