-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: template literal syntax in error handling for asset file paths #1267
fix: template literal syntax in error handling for asset file paths #1267
Conversation
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 207 207
Lines 10758 10758
Branches 2690 2690
=======================================
Hits 8994 8994
Misses 1764 1764 ☔ View full report in Codecov by Sentry. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is a PR that solves issue 1265.
Summary
This pull request corrects a syntax error in the template literal used for handling error messages regarding asset file paths within Metro. The existing implementation failed to properly format the file path in the error message. This change updates the syntax to correctly embed the file path variable into the error message.
Changelog: [Fix] Correct template literal syntax in error handling for asset file paths.
Test plan
To verify the correction, I conducted the following steps: