Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the delayed destruction from Handshake to QuicConnectionStateBase #88

Closed
wants to merge 1 commit into from

Conversation

deadalnix
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 24, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lnicco has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mjoras merged this pull request in e6e6196.

facebook-github-bot pushed a commit that referenced this pull request Feb 11, 2020
Summary:
This is similar to #88 except that in this case, QuicClientConnectionState is actually needed to move forward.
Pull Request resolved: #95

Reviewed By: yangchi

Differential Revision: D19816034

Pulled By: mjoras

fbshipit-source-id: a57b7a4732e3d7918369f8febbf63bce40d18a6c
facebook-github-bot pushed a commit that referenced this pull request Feb 12, 2020
…ke (#90)

Summary:
The cryptoState can be derrived from it, so it is redundant to pass it.

This PR depends on #88
Pull Request resolved: #90

Reviewed By: mjoras

Differential Revision: D19622581

Pulled By: yangchi

fbshipit-source-id: b3c88999199673f69c4422b96fbe7f2b0656bf6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants