Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new page documenting React Native's out-of-tree platform support #541

Merged
merged 3 commits into from
Sep 11, 2018

Conversation

empyrical
Copy link
Contributor

This PR adds a new page to the React Native docs that showcases other platforms that have been developed for React Native, and a bit documenting the API change that was added in facebook/react-native#20825 . In the future, this should be able to be expanded with more information on making/maintaining React Native platforms.

@react-native-bot
Copy link

react-native-bot commented Sep 1, 2018

Deploy preview for react-native ready!

Built with commit 8a0d3bb

https://deploy-preview-541--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link

@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mention haul in addition to metro.
It would be great to include the first couple of error messages (e.g. when Accessibility.platform.js is missing) and how to fix them.

@empyrical
Copy link
Contributor Author

I almost wonder if I should make a PR that throws an error if you pass a --platform that doesn't exist. Also Haul would be a good thing to mention, yes. But IIRC it only supports iOS/Android - a PR to remedy that could probably be made too!

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the typo is fixed I think this can be merged. I'll reply to what Matt wrote separately

docs/out-of-tree-platforms.md Outdated Show resolved Hide resolved
@kelset
Copy link
Contributor

kelset commented Sep 3, 2018

related to

It would be great to include the first couple of error messages (e.g. when Accessibility.platform.js is missing) and how to fix them.

We have been discussing about adding a "known issue" section to each component/page - you can check out how it would look here -> #519

So I think that if you want to add it you should follow that "approach"

@kelset kelset merged commit 3fd6b6d into facebook:master Sep 11, 2018
hramos added a commit that referenced this pull request Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants