Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command (⌘)-R is now recording the simulator in addition to reloading JS (Xcode 12.5) #31467

Closed
ferrannp opened this issue May 1, 2021 · 20 comments
Labels
Needs: Triage 🔍 p: Callstack Partner: Callstack Partner Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@ferrannp
Copy link
Contributor

ferrannp commented May 1, 2021

Description

Looks like the CMD-R mapping is taken now in XCode 12.5:

Screenshot 2021-05-01 at 19 51 29

React Native version:

N/A.

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.

  1. Open simulator in XCode 12.5
  2. Press CMD-R to reload JS, the simulator will start recording the screen

I did not find a way to prevent this. Should we map reloading JS to different keys?

@dulmandakh
Copy link
Contributor

Double R 👍

@anhtuank7c
Copy link

@dulmandakh It'll record the screen then reload the JS 😢

@dulmandakh
Copy link
Contributor

Just Double R, no command key

@ernestasgobionis
Copy link

ernestasgobionis commented May 3, 2021

Double R doesn't work on iOS simulator, I think that only works for Android. As a workaround for now I'm just using CMD+D to open the dev menu and reload it that way

@ferrannp
Copy link
Contributor Author

ferrannp commented May 3, 2021

Hey @dulmandakh ! Double R does not work on iOS simulator. And even if you could... When you were focus in some TextInput, that wouldn't work I guess.

As an alternative:

  • R key in the terminal running the packager
  • CMD+D and Reload as @ernestasgobionis suggested

But I am hoping we can map another CMD+ something in the simulator because I am recording ALL THE TIME by mistake 😂 .

@ferrannp ferrannp changed the title Command (⌘)-R is now recording the simulator a part from reloading JS (Xcode 12.5) Command (⌘)-R is now recording the simulator in addition to reloading JS (Xcode 12.5) May 3, 2021
@jonstuebe
Copy link

This is my work around: https://twitter.com/jonstuebe/status/1390384513927184385

@ferrannp
Copy link
Contributor Author

ferrannp commented May 8, 2021

Nice! Thank you @jonstuebe !

@RodolfoGS
Copy link
Contributor

How to remapping simulator screen record shortcut

First, open system preferences and open the Keyboard area.

image

Next:

  1. Click on Shortcuts
  2. Click App Shortcuts
  3. Click the plus button

image

  1. Select Other
  2. Shift + Cmd + G
  3. Enter in /Applications/Xcode.app/Contents/Developer/Applications/
  4. Select Simulator App
  5. Enter for Menu Title: "Record Screen"
  6. Click into the keyboard shortcut box and press your desired shortcut (Ex: Cmd + Shift + R)

image


Source: https://twitter.com/jonstuebe/status/1390384513927184385
Thanks @jonstuebe

@heyacherry
Copy link

Thanks @jonstuebe
Works for me

@likontech
Copy link

Thanks @jonstuebe

@JeffreyLeeDave
Copy link

That stops the whole command + R from recording for me, but I still can't refresh with command + R

@ValterSantosMatos
Copy link

ValterSantosMatos commented Aug 30, 2021

@JeffreyLeeDave, not exactly the same, but I added a shortcut on "command + R" to "Shake" the phone (so it opens the menu)

@nysamnang
Copy link

Short Answer:

We can remap simulator screen record shortcut following the steps below:

  1. Open Simulator
  2. Right click the icon in the tray
  3. Select Options > Show in Finder
  4. Copy Simulator.app to your /Applications directory
  5. Open System Preferences > Keyboard > Shortcuts
  6. Click App Shortcuts > add [+]
  7. Select the Simulator.app from the list
  8. Enter Menu Title Record Screen (or other name of the Simulator's Shortcut)
  9. Enter Keyboard Shortcut whatever you want
  10. Click Add
  11. Delete Simulator.app from /Applications
  12. Done! The shortcut will still be changeable.

@tijs
Copy link

tijs commented Sep 30, 2021

While workarounds are nice this is still a valid issue. So I hope the reload keyboard shortcut will be change in upcoming react native versions?

@tastycode
Copy link

Here's a simpler workaround, i perused the packager source and realized that there are some commands you can send to the bundler via a simple curl request. curl localhost:8081/reload will reload react native.

image

@sekomer
Copy link

sekomer commented Jun 7, 2023

single R keystroke reloads

@dnlgrgly
Copy link

@jonstuebe since Elon broke Twitter, non-users (including me) cannot see your actual solution 😢
Could you please share it here? :)

image

@liamjones
Copy link
Contributor

@dnlgrgly it's the instructions in the comment two posts below Jon's: #31467 (comment)

Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label May 12, 2024
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 p: Callstack Partner: Callstack Partner Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests