Update Modal.js

[Norfeldt]

Change default background color (when transparent prop is set to false) from white to semitransparent black.

#18398 - #18398

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[analysis-bot]

Code analysis results:

• eslint found some issues. Run yarn lint --fix to automatically fix problems.

[analysis-bot]

prettier/prettier: Replace ·?·'transparent' with ⏎········?·'transparent'⏎·······

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against ce4dfc7

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[cpojer]

When the transparent prop is off, then the color used shouldn't be using transparency so I'm not sure whether the motivation for this change makes sense. If you'd like us to consider this, could you go into more detail about what prompted this change and what this looks like before/after on devices?

[Norfeldt]

This PR was made in too much hast - sorry about that. Yours Sincerely *Lasse Nørfeldt*

…

On Mon, May 20, 2019 at 9:44 AM Christoph Nakazawa ***@***.***> wrote: When the transparent prop is off, then the color used shouldn't be using transparency so I'm not sure whether the motivation for this change makes sense. If you'd like us to consider this, could you go into more detail about what prompted this change and what this looks like before/after on devices? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24949?email_source=notifications&email_token=AAFFXFUYL5TKB5GGMT473B3PWJJENA5CNFSM4HN4QCE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVX6RHQ#issuecomment-493873310>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFFXFWEO2JMDT2YMXRUOOTPWJJENANCNFSM4HN4QCEQ> .