add-coverage-to-gitignore #35809
Closed
add-coverage-to-gitignore #35809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Adnan-Bacic
changed the title
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Jan 11, 2023
Base commit: 4d8ba7b |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: There is a large amount of autogenerated files in the coverage folder when running `jest --coverage`. This folder is also in .gitignore for react projects created with `create-react-app` Originally suggested here: react-native-community/discussions-and-proposals#569 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [ADDED] - Added "coverage" folder generated på `jest --coverage` to .gitignore Pull Request resolved: facebook#35809 Test Plan: 1. cd template 2. yarn 3. yarn test --coverage Im not sure why many of the files in the template folder have an underscore(_) in the filenames instead of a dot(.). When creating a react-native project they have a dot. So if you run the above commands, the coverage folder will not be ignored since its not in `.gitingore` but in `_gitignore`. However, if you temporarily create a `.gitignore` file, you will see that the coverage folder is ignored. 4. Temporarily create `.gitignore` file to verify that coverage folder is ignored Reviewed By: cortinico Differential Revision: D42454560 Pulled By: jacdebug fbshipit-source-id: 0be007d3ba3dde47814c0ce0fb8b0ff9f67d637b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a large amount of autogenerated files in the coverage folder when running
jest --coverage.This folder is also in .gitignore for react projects created with
create-react-appOriginally suggested here: react-native-community/discussions-and-proposals#569
Changelog
[GENERAL] [ADDED] - Added "coverage" folder generated by
jest --coverageto .gitignoreTest Plan
Im not sure why many of the files in the template folder have an underscore(_) in the filenames instead of a dot(.). When creating a react-native project they have a dot. So if you run the above commands, the coverage folder will not be ignored since its not in
.gitingorebut in_gitignore. However, if you temporarily create a.gitignorefile, you will see that the coverage folder is ignored..gitignorefile to verify that coverage folder is ignored