Move jest config from package.json to dedicated jest.config.js file #35856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
robhogan
approved these changes
Jan 17, 2023
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 55af2fe |
Adnan-Bacic
deleted the
move-jest-config-from-package.json-to-dedicated-jest.config.js-file
branch
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…acebook#35856) Summary: According to: https://jestjs.io/docs/configuration > It is recommended to define the configuration in a dedicated JavaScript, TypeScript or JSON file. The file will be discovered automatically, if it is named jest.config.js|ts|mjs|cjs|json. react-native projects have the jest config in package.json, this change aims to follow jest recommendations and have a dedicated file for jest configs. Originally suggested here: react-native-community/discussions-and-proposals#583 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [CHANGED] - Moved jest config from package.json to dedicated jest.config.js file Pull Request resolved: facebook#35856 Test Plan: 1. cd template 2. yarn 3. yarn test The test should (still) pass Reviewed By: christophpurrer Differential Revision: D42544351 Pulled By: robhogan fbshipit-source-id: e27d1dad2b52d757777c40a77d0639f381557c88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to: https://jestjs.io/docs/configuration
react-native projects have the jest config in package.json, this change aims to follow jest recommendations and have a dedicated file for jest configs.
Originally suggested here: react-native-community/discussions-and-proposals#583
Changelog
[GENERAL] [CHANGED] - Moved jest config from package.json to dedicated jest.config.js file
Test Plan
The test should (still) pass