Try to parametrize executors to use the min Xcode version for some jobs #39602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/add_job_with_Xcode14.1
branch
from
604fcec
to
ecbe2af
Compare
Base commit: e8a0f0d |
cipolleschi
force-pushed
the
cipolleschi/add_job_with_Xcode14.1
branch
2 times, most recently
from
06b2949
to
7fe9e18
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/add_job_with_Xcode14.1
branch
from
7fe9e18
to
43daf79
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/add_job_with_Xcode14.1
branch
from
43daf79
to
132020e
Compare
cipolleschi
force-pushed
the
cipolleschi/add_job_with_Xcode14.1
branch
from
132020e
to
2899299
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in fdd62e9. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
…bs (facebook#39602) Summary: App can be submitted to the app store by using Xcode 14.1 as min Xcode version. Right now we are testing everything against the latests Xcode, but it would be good to have some tests to check that we don't break the flow for people stuck on older Xcodes. We already had issues like these in the past, unfortunately. Plus, we are making some changes using C++20 which we don't know whether they are properly supported by older versions of Xcode. This change should give us confidence on those changes too. ## Changelog: [Internal] - Use Xcode 14.1 for some tests Pull Request resolved: facebook#39602 Test Plan: CircleCI is green Reviewed By: NickGerleman Differential Revision: D49540292 Pulled By: cipolleschi fbshipit-source-id: 71c07293598fd5b1f73f6d7d9425f385aa12fc4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
App can be submitted to the app store by using Xcode 14.1 as min Xcode version.
Right now we are testing everything against the latests Xcode, but it would be good to have some tests to check that we don't break the flow for people stuck on older Xcodes.
We already had issues like these in the past, unfortunately.
Plus, we are making some changes using C++20 which we don't know whether they are properly supported by older versions of Xcode.
This change should give us confidence on those changes too.
Changelog:
[Internal] - Use Xcode 14.1 for some tests
Test Plan:
CircleCI is green