-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbolicate unhandled promise rejections #40914
Closed
Closed
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8d1ce80
Symbolicate unhandled promise rejections and try to log them
ospfranco cb897d0
Linting
ospfranco c488217
change paths for devtools
ospfranco 516deee
change paths for devtools
ospfranco ff6be9c
Fix flow errors
ospfranco c460d5f
Allow passing stack into addLog
ospfranco a54fd6b
Do not symbolicate stack on promiseRejectionTrackingOptions but let l…
ospfranco 2a8a491
remove unused codeFrame
ospfranco 352ab9f
Revert outdated change to rejectionTrackingOptions type
ospfranco 07a48c2
Parse error stack on LogBoxData
ospfranco 1443452
re-insert blank line
ospfranco e5eed45
PR comments
ospfranco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,9 @@ | |
|
||
import typeof {enable} from 'promise/setimmediate/rejection-tracking'; | ||
|
||
let rejectionTrackingOptions: $NonMaybeType<Parameters<enable>[0]> = { | ||
type ExtractOptionsType = <P>(((options?: ?P) => void)) => P; | ||
|
||
let rejectionTrackingOptions: $Call<ExtractOptionsType, enable> = { | ||
allRejections: true, | ||
onUnhandled: (id, rejection = {}) => { | ||
let message: string; | ||
|
@@ -22,7 +24,50 @@ let rejectionTrackingOptions: $NonMaybeType<Parameters<enable>[0]> = { | |
// $FlowFixMe[method-unbinding] added when improving typing for this parameters | ||
message = Error.prototype.toString.call(rejection); | ||
const error: Error = (rejection: $FlowFixMe); | ||
stack = error.stack; | ||
|
||
// Print pretty unhandled rejections while on DEV | ||
if (__DEV__) { | ||
const parseErrorStack = require('./Core/Devtools/parseErrorStack'); | ||
const symbolicateStackTrace = require('./Core/Devtools/symbolicateStackTrace'); | ||
const LogBox = require('./LogBox/LogBox').default; | ||
|
||
const parsedStack = parseErrorStack(error.stack); | ||
|
||
symbolicateStackTrace(parsedStack) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This shouldn't live here. Logbox can handle this better by first showing the unsymbolicated stacktrace and then replacing the relevant log when the symbolication is ready. |
||
.then(prettyStack => { | ||
let warning = | ||
`Possible Unhandled Promise Rejection (id: ${id}):\n` + | ||
`${message ?? ''}\n`; | ||
|
||
if (prettyStack.codeFrame != null) { | ||
warning += `at File: ${prettyStack.codeFrame.fileName}, row: ${ | ||
prettyStack.codeFrame.location?.row ?? 'Unknown' | ||
}, column: ${ | ||
prettyStack.codeFrame.location?.column ?? 'Unknown' | ||
}`; | ||
|
||
LogBox.addLog({ | ||
level: 'warn', | ||
message: {content: warning, substitutions: []}, | ||
componentStack: [], | ||
codeFrame: prettyStack.codeFrame, | ||
category: `${prettyStack.codeFrame.fileName}-${ | ||
prettyStack.codeFrame.location?.row ?? 'unknown' | ||
}-${prettyStack.codeFrame.location?.column ?? 'unknown'}`, | ||
}); | ||
} else { | ||
console.warn(warning); | ||
} | ||
}) | ||
.catch(() => { | ||
const warning = | ||
`Possible Unhandled Promise Rejection (id: ${id}):\n` + | ||
`${message ?? ''}\n` + | ||
(stack == null ? '' : stack); | ||
console.warn(warning); | ||
}); | ||
return; | ||
} | ||
} else { | ||
try { | ||
message = require('pretty-format')(rejection); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try this to reuse the same parsing logic for both