-
Notifications
You must be signed in to change notification settings - Fork 46.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make uncontrolled -> controlled warning clearer #17070
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I would suggest adding a sentence like "This is likely caused by |
|
Looks like this was upgraded to an error since I opened the PR. Fixing conflicts. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dbe2dcc:
|
No rush on this, but anything else needed for it to land? cc @sophiebits @gaearon |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
@vcarl Sorry, there's a huge backlog and things slip through. I wanted to merge this but now the ref is gone. :-( |
I restored the branch, but am unsubscribing from the PR. If it lands, cool! But I'm moving on. |
Thanks! |
Fixes #17069. Glad to iterate further on the specific language, but I've found that explaining in this way usually clears it up for people.