-
Notifications
You must be signed in to change notification settings - Fork 46.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: honor displayName of context types #18224
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2176e6d:
|
Details of bundled changes.Comparing: 3ee812e...2176e6d react
React: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 3ee812e...2176e6d react
React: size: 0.0%, gzip: 0.0% Size changes (experimental) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better to me, but cc @trueadm to make sure I'm not overlooking something about this internal case.
I ran a local sync on this version and verified that the internal test the previous PR broke passes now. |
Summary
New iteration of #18035 which had to be reverted (#18223) since setting
Context.Consumer.displayName
would throw.Setting
Context.Consumer.displayName
ignores the given value but emits warning. As far as I can tell this doesn't do anything onmaster
: https://codesandbox.io/s/priceless-hooks-lm0kyTest Plan
@trueadm should sign this off since this affects internal tests. If a warning is still too loud we could put it behind a flag that we turn off for the fb builds.