-
Notifications
You must be signed in to change notification settings - Fork 46.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StrictMode): Double-invoke render for every component #18430
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e508cee:
|
Details of bundled changes.Comparing: 1af2a10...e508cee react-art
react-dom
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 1af2a10...e508cee react-dom
react-art
react-native-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Seems like bundle tests fail. |
It seems like react-test-renderer is not using Apparently |
Following https://github.com/facebook/react/pull/14639/files#diff-0b241de0dfec2d07bb2b2fef76b254d2R11-R24 though I don't think I understand the distinction between source and build tests. |
Not sure what you mean by this. In the bundle tests, The difference is that you can't set feature flags for bundle tests. Because nothing will read them. They're already compiled away. |
Looks good. Thanks. |
Summary
Closes #18426.
Essentially #14639 rebased with
master
where concerns were voiced about existing tests.Test Plan
ReactHooks-internal is responsible for this test. This also affects any test counting renders.