-
Notifications
You must be signed in to change notification settings - Fork 46.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReactDOM: remove unstable-native-dependencies bundle #18483
ReactDOM: remove unstable-native-dependencies bundle #18483
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9fe5ee0:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do we actually merge this? Before the official RNW release has it or after? Seems like we should wait until there's actually an upgrade path? Since this is a breaking change, I think it'll also have to wait until we're finished releasing minors and are ready for a major.
Probably. I'm expecting to get the replacement into RNW by the end of the month. This doesn't strictly need to go out in a major, since previous breaking changes in these files have occurred in patch releases. However, if there's anything else related to the plugin system that we want to remove once this is merged, then it would make sense to package it all up in a major. |
b6d14ac
to
66b1903
Compare
This is only used by react-native-web and will be replaced by a user-space implementation. See: necolas/react-native-web#1568
66b1903
to
9fe5ee0
Compare
I'm happy to merge this now, and will be responsible for managing the downstream effects. |
This is only used by react-native-web and will be replaced by a user-space
implementation
Summary
See: necolas/react-native-web#1568
Test Plan
CI