Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requiring timers module with non standard require #18632

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Fix requiring timers module with non standard require #18632

merged 1 commit into from
Apr 16, 2020

Conversation

just-boris
Copy link
Contributor

Summary

A fix for #18589

Test Plan

Ran "steps to reproduce" from the report. Fails before and passes after the fix.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d0a0ff:

Sandbox Source
inspiring-butterfly-4y5v1 Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 39ed538:

Sandbox Source
stoic-kilby-u44e1 Configuration

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks for fixing.

@gaearon gaearon merged commit 7b4403c into facebook:master Apr 16, 2020
@sebmarkbage
Copy link
Collaborator

@gaearon Let's rethink this whole thing. It has grown beyond its original state slowly by slowly until now being hacks on hacks and bloated.

This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants