-
Notifications
You must be signed in to change notification settings - Fork 46.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-dom): Add enterKeyHint #18634
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c75389:
|
deleted by accident |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
bump |
Looks like we forgot to merge. Thanks! |
Summary
Test Plan
Ran /fixtures/attribute-behavior locally. Results available under https://drive.google.com/open?id=1j5PJgc-NcKXsGZh8GqBfHXHfdEwd9ii_.
Note: Should I update the fixture for
inputMode
as well? It is still reading from the attribute but the property is supported as of chrome 66.react/fixtures/attribute-behavior/src/attributes.js
Line 955 in 8c75389
Codesandbox using this PR: https://codesandbox.io/s/enterkeyhint-6l5t3