Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble onSubmit/onReset behind a feature flag #19333

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 13, 2020

Same as #19285, but behind a feature flag so it's less of a risk. The flag is off by default, but is adjustable in WWW.

Essentially this is a comeback of #13358. When we tried it last time, it broke a few things internally, and we had to roll back. But it's possible that this code no longer exists. Or maybe we can fix it in the product. So let's give it another try and be more careful this time.

We are doing this now so that we can remove these two events from the special capture phase list. And as a result, fix event replaying for them.

@gaearon gaearon requested a review from trueadm July 13, 2020 16:09
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 13, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 771048b:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 13, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 771048b

@sizebot
Copy link

sizebot commented Jul 13, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 771048b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants