Skip to content

Commit

Permalink
Add context for clippy warning
Browse files Browse the repository at this point in the history
Summary:
In D53729268, we started using generic_asserts for better visibility in unit test failures. This makes us use the feature `generic_assert` but also forces us to use `core_intrinsics` which is not strictly needed. The only reason we are forced to use this is [this bug](rust-lang/rust#120612).

Clippy doesn't like that we are using compiler internal stuff and gives a strong warning. Since we can't do anything about it, I have added a comment to provide context on why this cannot be fixed currently.

Reviewed By: YousefSalama, singhsrb

Differential Revision: D54061913

fbshipit-source-id: f5b952bfe13dc0e5af17b5b28c3d18adf43ba000
  • Loading branch information
RajivTS authored and facebook-github-bot committed Feb 22, 2024
1 parent cda05d3 commit 056fbb8
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

#![feature(generic_assert)]
// The clippy lint is not our fault and is a result of the bug https://fburl.com/7perds28
#![feature(core_intrinsics)]

mod ratelimit;
Expand Down

0 comments on commit 056fbb8

Please sign in to comment.