Bump .cartfile versions to match .Podspec #3249
Conversation
Podspec was bumped in 75fddb1, this bumps the cartfile to match
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Looks good to me, but I think @garrettmoon should also take a quick look over it.
| @@ -1,2 +1,2 @@ | |||
| github "pinterest/PINRemoteImage" "3.0.0-beta.6" | |||
| github "pinterest/PINCache" "3.0.1-beta.2" | |||
| github "pinterest/PINRemoteImage" "3.0.0-beta.8" | |||
There was a problem hiding this comment.
I think we're on beta.9 now
There was a problem hiding this comment.
Which is my fault, should have reviewed this sooner :D
|
Yup, spotted this yesterday. Want me to bump this too?
… On 14 Apr 2017, at 10:00, Garrett Moon ***@***.***> wrote:
@garrettmoon commented on this pull request.
In Cartfile:
> @@ -1,2 +1,2 @@
-github "pinterest/PINRemoteImage" "3.0.0-beta.6"
-github "pinterest/PINCache" "3.0.1-beta.2"
+github "pinterest/PINRemoteImage" "3.0.0-beta.8"
I think we're on beta.9 now
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Yes please :) |
|
Hey, sorry we didn't get this in yet. AsyncDisplayKit is becoming Texture! Would you mind reopening your pull request there: https://github.com/TextureGroup/Texture/pulls More info about the rename here: https://medium.com/@Pinterest_Engineering/introducing-texture-a-new-home-for-asyncdisplaykit-e7c003308f50 |
|
Diff moved! |
Podspec was bumped in 75fddb1, this bumps the cartfile to match
Still using Xcode 8.2.1 so not suffering from the issues as part of #2983. Would be nice if we could bump the versions independently of fixing the Xcode 8.3 issues