Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[antlir/metalos][oss] fix some third party deps builds #249

Closed
wants to merge 1 commit into from

Conversation

vmagro
Copy link
Contributor

@vmagro vmagro commented Jul 18, 2024

Summary: Title

Test Plan:

❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta

Differential Revision: D59928725

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 18, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 18, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 18, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2024
Summary:

Title

Test Plan:
```
❯ buck build //third-party/rust:ring-0.17.8
Build ID: e40e98af-65fc-4844-bc1a-333876188cae
Network: Up: 0B  Down: 4.0MiB
Jobs completed: 17. Time elapsed: 1.1s.
Cache hits: 0%. Commands: 3 (cached: 0, remote: 0, local: 3)
BUILD SUCCEEDED
metalos//third-party/rust:ring-0.17.8 buck-out/v2/gen/metalos/904931f735703749/third-party/rust/__ring-0.17.8__/out/rlib-pic-static_pic-metadata-fast-diag/libring-228647f1.rmeta

❯ buck build //third-party/rust:reqwest
Build ID: 9c1bf166-3835-485a-96fd-05b44bcd3abf
Network: Up: 0B  Down: 0B
Jobs completed: 13. Time elapsed: 0.9s.
Cache hits: 0%. Commands: 4 (cached: 0, remote: 0, local: 4)
BUILD SUCCEEDED
antlir//third-party/rust:reqwest buck-out/v2/gen/antlir/904931f735703749/third-party/rust/__reqwest-0.11.27__/out/rlib-pic-static_pic-metadata-fast-diag/libreqwest-79d51cdc.rmeta
```

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

vmagro added a commit that referenced this pull request Jul 19, 2024
Summary:
Pull Request resolved: #249

Title

Test Plan:
```name="Third-party deps of bootloader build"
❯ buck build --keep-going //metalos/bootloader:metalos-bootloader
Action failed: metalos//metalos/lib/tracing:metalos_tracing (rustc rlib)
Local command returned non-zero exit code 1
Reproduce locally: `env -- 'BUCK_SCRATCH_PATH=buck-out/v2/tmp/metalos/e85947776b662505/rustc/rlib' /usr/bin/env 'PYTHONP ...<omitted>... 03749/metalos/lib/tracing/__metalos_tracing__/rlib-static-static-link/metalos_tracing-link-diag.args (run `buck2 log what-failed` to get the full command)`
stdout:
stderr:
error: external crate `fbinit` unused in `metalos_tracing`: remove the dependency or add `use fbinit as _;`
  |
  = note: requested on the command line with `-F unused-crate-dependencies`

error: aborting due to 1 previous error

Action failed: metalos//metalos/lib/tracing:metalos_tracing (rustc metadata [static])
Local command returned non-zero exit code 1
Reproduce locally: `env -- 'BUCK_SCRATCH_PATH=buck-out/v2/tmp/metalos/e85947776b662505/rustc/_buck_749b01f6d1bd8e8c' /us ...<omitted>... tracing/__metalos_tracing__/rlib-static-static-metadata-full/metalos_tracing-metadata-full-diag.args (run `buck2 log what-failed` to get the full command)`
stdout:
stderr:
error: external crate `fbinit` unused in `metalos_tracing`: remove the dependency or add `use fbinit as _;`
  |
  = note: requested on the command line with `-F unused-crate-dependencies`

error: aborting due to 1 previous error

Build ID: 4bdfc708-d862-427e-b07e-87e3205a72cf
Network: Up: 0B  Down: 0B
Jobs completed: 5290. Time elapsed: 29.0s.
Cache hits: 0%. Commands: 1282 (cached: 0, remote: 0, local: 1282)
BUILD FAILED
Failed to build 'metalos//metalos/lib/tracing:metalos_tracing (prelude//platforms:default#904931f735703749)'
```

Differential Revision: D59928725
Summary:
Pull Request resolved: #249

Title

Test Plan:
```name="Third-party deps of bootloader build"
❯ buck build --keep-going //metalos/bootloader:metalos-bootloader
Action failed: metalos//metalos/lib/tracing:metalos_tracing (rustc rlib)
Local command returned non-zero exit code 1
Reproduce locally: `env -- 'BUCK_SCRATCH_PATH=buck-out/v2/tmp/metalos/e85947776b662505/rustc/rlib' /usr/bin/env 'PYTHONP ...<omitted>... 03749/metalos/lib/tracing/__metalos_tracing__/rlib-static-static-link/metalos_tracing-link-diag.args (run `buck2 log what-failed` to get the full command)`
stdout:
stderr:
error: external crate `fbinit` unused in `metalos_tracing`: remove the dependency or add `use fbinit as _;`
  |
  = note: requested on the command line with `-F unused-crate-dependencies`

error: aborting due to 1 previous error

Action failed: metalos//metalos/lib/tracing:metalos_tracing (rustc metadata [static])
Local command returned non-zero exit code 1
Reproduce locally: `env -- 'BUCK_SCRATCH_PATH=buck-out/v2/tmp/metalos/e85947776b662505/rustc/_buck_749b01f6d1bd8e8c' /us ...<omitted>... tracing/__metalos_tracing__/rlib-static-static-metadata-full/metalos_tracing-metadata-full-diag.args (run `buck2 log what-failed` to get the full command)`
stdout:
stderr:
error: external crate `fbinit` unused in `metalos_tracing`: remove the dependency or add `use fbinit as _;`
  |
  = note: requested on the command line with `-F unused-crate-dependencies`

error: aborting due to 1 previous error

Build ID: 4bdfc708-d862-427e-b07e-87e3205a72cf
Network: Up: 0B  Down: 0B
Jobs completed: 5290. Time elapsed: 29.0s.
Cache hits: 0%. Commands: 1282 (cached: 0, remote: 0, local: 1282)
BUILD FAILED
Failed to build 'metalos//metalos/lib/tracing:metalos_tracing (prelude//platforms:default#904931f735703749)'
```

Reviewed By: sergeyfd

Differential Revision: D59928725
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59928725

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 37a585d.

@vmagro vmagro deleted the export-D59928725 branch August 9, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants