💡 Updated eventEmitter comments with links

facebookresearch · Aug 3, 2022 · 0d5086c · 0d5086c
1 parent d65b46c
commit 0d5086c
Show file tree

Hide file tree

Showing 5 changed files with 2,868 additions and 57 deletions.
diff --git a/mephisto/abstractions/blueprints/static_html_task/source/dev/app.jsx b/mephisto/abstractions/blueprints/static_html_task/source/dev/app.jsx
@@ -123,7 +123,7 @@ function SubmitFrame({ children, onSubmit, currentTask }) {
   React.useEffect(() => {
     // Reset submitting when switching from onboarding
     setSubmitting(false);
-  }, []);
+  }, [currentTask]);
 
   function handleFormSubmit(event) {
     event.preventDefault();

diff --git a/mephisto/abstractions/blueprints/static_html_task/source/dev/hooks.js b/mephisto/abstractions/blueprints/static_html_task/source/dev/hooks.js
@@ -2,13 +2,13 @@ import { useState, useCallback, useEffect } from "react";
 
 /**
  * This hook is to be used with events that are supposed to update state when they are consumed.
- * @param {string} eventName
+ * @param {string} configName
  * @param {any} defaultValue
  * @param {function} validatorFunction
  * @returns [any any]
  */
 export function useMephistoGlobalConfig(
-  eventName,
+  configName,
   defaultValue,
   validatorFunction
 ) {
@@ -26,7 +26,7 @@ export function useMephistoGlobalConfig(
   );
 
   useEffect(() => {
-    window._MEPHISTO_CONFIG_.EVENT_EMITTER.on(eventName, handleEvent);
+    window._MEPHISTO_CONFIG_.EVENT_EMITTER.on(configName, handleEvent);
   }, [setConfigState]);
 
   return [configState, setConfigState];