Merge pull request #1039 from PReithofer/main

quick fix: change order of checks in operator
facebookresearch · Aug 1, 2023 · 2922d0f · 2922d0f
2 parents eca15cd + cfe15c3
commit 2922d0f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/mephisto/operations/operator.py b/mephisto/operations/operator.py
@@ -338,15 +338,15 @@ async def _track_and_kill_runs(self):
                     tracked_run.force_shutdown = True
                 if not tracked_run.force_shutdown:
                     task_run = tracked_run.task_run
-                    if tracked_run.task_launcher.finished_generators is False:
-                        # If the run can still generate assignments, it's
-                        # definitely not done
-                        continue
                     task_run.update_completion_progress(
                         task_launcher=tracked_run.task_launcher
                     )
                     if not task_run.get_is_completed():
                         continue
+                    if tracked_run.task_launcher.finished_generators is False:
+                        # If the run can still generate assignments, it's
+                        # definitely not done
+                        continue
 
                 tracked_run.client_io.shutdown()
                 tracked_run.worker_pool.shutdown()