Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility to reset worker's onboarding status #790

Closed
xksteven opened this issue Jun 10, 2022 · 1 comment · Fixed by #886
Closed

Utility to reset worker's onboarding status #790

xksteven opened this issue Jun 10, 2022 · 1 comment · Fixed by #886
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@xksteven
Copy link
Contributor

xksteven commented Jun 10, 2022

I tried to find the answer but the link in [architecture overview] is broken(https://github.com/facebookresearch/Mephisto/blob/main/packages/mephisto-task/README.md#agentid). Not sure where that info would be in the documentation.

I've been debugging locally and I've been testing out that I can fail the onboarding task but I don't know how to reset the default user.

Issue #748 is a slight duplicate but refers to another repo namely ParlAI for their instructions. It's not clear how to do this in general in Mephisto.

@JackUrb
Copy link
Contributor

JackUrb commented Jun 11, 2022

Hi @xksteven - thanks for the question! This would likely be a good candidate to add as a util to the OnboardingRequired mixin (OnboardingRequired.clear_onboarding(worker, qualification_name)), and then adding to the onboarding docs. I'm currently on vacation, but in the meantime you can see the qualifications associated with onboarding here:

worker.grant_qualification(
blueprint.onboarding_qualification_name, int(worker_passed)
)
if not worker_passed:
ONBOARDING_OUTCOMES.labels(outcome="failed").inc()
worker.grant_qualification(
blueprint.onboarding_failed_name, int(worker_passed)
)

With this info you can use revoke_qualification on both of the related qualifications to clear an individual worker.

For other possible solutions, if you're just clearing for yourself in local for testing, you can simply change your own worker id. If you want to 'reset' all workers for a task, you can just change the onboarding_qualification.

@JackUrb JackUrb changed the title How to reset workers who've failed onboarding? Utility to reset worker's onboarding status Jun 11, 2022
@JackUrb JackUrb added enhancement New feature or request good first issue Good for newcomers labels Jun 11, 2022
pringshia added a commit that referenced this issue Jun 20, 2022
Fixes broken link issue mentioned in #790
pringshia added a commit that referenced this issue Jun 20, 2022
Fixes broken link issue mentioned in #790
@Etesam913 Etesam913 self-assigned this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants