-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mephisto check should output to stderr if it fails #916
Comments
Hi @mjkanji - this is a good point, much of Mephisto hasn't been built with this particular setting in mind, but it would definitely be an improvement for us to do. I think it'd be appropriate at least here (and eventually in other scripts utilities) to switch to |
@JackUrb That sounds good to me! Though, I'm not sure I understand why one message use
From my cursory look at |
@pringshia do you have any intuition as to why some of the cli uses |
Yes, |
The
mephisto check
command currently uses a print statement andclick.echo()
when it fails. This results in silent errors which may not be picked up by a CI/CD tool.For example, in this run of the Docker Testing Matrix job, the 'Check that Mephisto was installed correctly' stage passes, but if you look at the details,
mephisto check
actually fails:The text was updated successfully, but these errors were encountered: