Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #874: Upgrade pip and create main_data_directory in Dockerfile #917

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

mjkanji
Copy link
Contributor

@mjkanji mjkanji commented Oct 12, 2022

This PR fixes #874 by updating pip in the Dockerfile.

Also creates the /mephisto/data/ directory which is specified as the main_data_directory in config.yml. This was leading to a silent error when running mephisto check. (See #916).

@mjkanji mjkanji marked this pull request as ready for review October 12, 2022 13:56
@JackUrb
Copy link
Contributor

JackUrb commented Oct 12, 2022

Thanks for the fix here @mjkanji!

@JackUrb JackUrb merged commit 22097c7 into facebookresearch:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build failing after poetry transition
2 participants