Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissive socket upload #1026

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Permissive socket upload #1026

merged 2 commits into from
Jun 27, 2023

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Jun 26, 2023

Overview

Based on a followup issue caused by the Amazon Linux 2 repo server issues we've had lately (#1023 current bandage), we've found that our WebsocketChannel server fails pretty reliably when we run into a handshake failure during initialization. This PR adds retriability for the initial handshake, as the server may still just be warming up.

@JackUrb JackUrb requested a review from meta-paul June 26, 2023 19:00
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.11 ⚠️

Comparison is base (32a0cd1) 63.97% compared to head (a4c504c) 63.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
- Coverage   63.97%   63.87%   -0.11%     
==========================================
  Files         108      108              
  Lines        9452     9461       +9     
==========================================
- Hits         6047     6043       -4     
- Misses       3405     3418      +13     
Impacted Files Coverage Δ
...tractions/architects/channels/websocket_channel.py 64.96% <22.22%> (-3.01%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JackUrb JackUrb merged commit 2cf37b0 into main Jun 27, 2023
13 checks passed
@JackUrb JackUrb deleted the permissive-socket-upload branch June 27, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants