Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to get_status complexity #1037

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changes to get_status complexity #1037

wants to merge 2 commits into from

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Jul 27, 2023

Overview

The get_status function for MTurkUnits and MTurkAgents has, for a while, been way more obtuse than necessary. We remove the strange situation where MTurkUnits request information from MTurk about MTurkAgents indirectly, then push updates downwards to the MTurkAgent. This is instead replaced by the MTurkAgent having more autonomy in updating its status based on the provider, allowing the expected state changes upwards to occur cleanly.

Testing

Not tested yet

@JackUrb JackUrb requested a review from meta-paul July 27, 2023 19:34
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 27, 2023
@JackUrb JackUrb marked this pull request as ready for review August 22, 2023 18:51
@facebook-github-bot
Copy link
Contributor

Hi @JackUrb!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants