Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick fix: change order of checks in operator #1039

Merged
merged 1 commit into from
Aug 1, 2023
Merged

quick fix: change order of checks in operator #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions mephisto/operations/operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,15 +338,15 @@ async def _track_and_kill_runs(self):
tracked_run.force_shutdown = True
if not tracked_run.force_shutdown:
task_run = tracked_run.task_run
if tracked_run.task_launcher.finished_generators is False:
# If the run can still generate assignments, it's
# definitely not done
continue
task_run.update_completion_progress(
task_launcher=tracked_run.task_launcher
)
if not task_run.get_is_completed():
continue
if tracked_run.task_launcher.finished_generators is False:
# If the run can still generate assignments, it's
# definitely not done
continue

tracked_run.client_io.shutdown()
tracked_run.worker_pool.shutdown()
Expand Down