Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logger in Python code #1045

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Improve logger in Python code #1045

merged 2 commits into from
Aug 10, 2023

Conversation

meta-paul
Copy link
Contributor

Deprecated RichHandler that messed up log formatting. Made output for Hydra logger (main code) and command-line scripts consistent.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2023
@meta-paul meta-paul requested a review from JackUrb August 9, 2023 19:12
@JackUrb
Copy link
Contributor

JackUrb commented Aug 10, 2023

Consistency > style in general, so I'll pull this in, but I will miss the nice formatting of the rich-based logs.

@JackUrb JackUrb merged commit 24905d7 into main Aug 10, 2023
12 of 13 checks passed
@JackUrb JackUrb deleted the improve-logger branch August 10, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants