Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2 #1092

Merged
merged 52 commits into from
Dec 27, 2023
Merged

Release v1.2 #1092

merged 52 commits into from
Dec 27, 2023

Conversation

meta-paul
Copy link
Contributor

No description provided.

meta-paul and others added 30 commits August 25, 2023 19:40
Laying down basic strokes of standard get_data response
Update copyright headers across the codebase
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 15, 2023
@JackUrb
Copy link
Contributor

JackUrb commented Dec 17, 2023

We'll want to get doc deployment + code style squared away before this goes in. Unsure why we have some test failings here too.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c75caa) 60.38% compared to head (1f4fe78) 62.71%.
Report is 21 commits behind head on main.

❗ Current head 1f4fe78 differs from pull request most recent head aba6369. Consider uploading reports for the commit aba6369 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   60.38%   62.71%   +2.32%     
==========================================
  Files         155      179      +24     
  Lines       11822    12594     +772     
==========================================
+ Hits         7139     7898     +759     
- Misses       4683     4696      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meta-paul meta-paul force-pushed the v1.2-dev branch 2 times, most recently from bdc8c18 to 1f4fe78 Compare December 19, 2023 17:28
@meta-paul
Copy link
Contributor Author

meta-paul commented Dec 19, 2023

@JackUrb Sure thing! I usually leave fixing of failing checks to the very last stage, and I've just done that. Everything is passing now.

Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Glad to have this together! Sorry for the review delays

@meta-paul meta-paul merged commit aac76d7 into main Dec 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants