Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display qualifications granted to a worker in TaskReview app #1127

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

meta-paul
Copy link
Contributor

When granting qualification to a worker in the TaskReview app, the reviewer will be able to see already granted qualifications.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2024
@meta-paul meta-paul force-pushed the show-worker-quals-during-review branch from 3f8b4ab to a4b4a98 Compare March 19, 2024 02:40
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 60.35%. Comparing base (cd04708) to head (a4b4a98).

Files Patch % Lines
...er/api/views/worker_granted_qualifications_view.py 39.13% 14 Missing ⚠️
...r/api/views/unit_data_static_by_field_name_view.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
+ Coverage   60.31%   60.35%   +0.04%     
==========================================
  Files         209      210       +1     
  Lines       14773    14798      +25     
==========================================
+ Hits         8910     8932      +22     
- Misses       5863     5866       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meta-paul meta-paul merged commit 20cb90b into main Mar 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants