bootstrap-chat docs update
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 66.57% 66.59% +0.01%
==========================================
Files 74 74
Lines 6627 6627
==========================================
+ Hits 4412 4413 +1
+ Misses 2215 2214 -1
Continue to review full report at Codecov.
|
JackUrb
reviewed
Oct 8, 2020
pringshia
commented
Oct 8, 2020
pringshia
commented
Oct 8, 2020
pringshia
commented
Oct 8, 2020
pringshia
commented
Oct 8, 2020
pringshia
commented
Oct 22, 2020
pringshia
changed the title
bootstrap-chat docs updatebootstrap-chat docs update
JackUrb
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Great docs - really solid overview for how bootstrap-chat is intended to be used, and important documentation of the heaviest-lifting parts of the package.
Reading through though, it may be also good to document some of the more-likely-to-be-used underlying components, such as ChatMessage, perhaps in a bootstrap-chat/src/README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished up the
bootstrap-chatdocs.Have one minor note below regarding the
IDLEstate forINPUT_MODEwhich doesn't seem to be ever set anywhere. Should we remove? Or does this represent a future feature we will be adding regarding idleness/timeouts?