Adding tutorial stubs to docusaurus #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## docusaurus #613 +/- ##
==============================================
- Coverage 63.24% 63.11% -0.13%
==============================================
Files 86 86
Lines 8230 8242 +12
==============================================
- Hits 5205 5202 -3
- Misses 3025 3040 +15
Continue to review full report at Codecov.
|
|
Looks good - liking the structure and organization. I've updated the OP with a screenshot of the high level categories in the side bar. |
pringshia
approved these changes
Dec 6, 2021
pringshia
reviewed
Dec 6, 2021
.gitignore
Outdated
| # Examples | ||
| examples/simple_static_task/hydra_configs/conf/* | ||
| !examples/simple_static_task/hydra_configs/conf/example.yaml | ||
| !examples/simple_static_task/hydra_configs/conf/onboardiing_example.yaml |
There was a problem hiding this comment.
looks like a typo, extra "i" in "onboardiing"
| @@ -26,7 +26,7 @@ | |||
| "file-loader": "^6.0.0", | |||
| "style-loader": "^0.23.0", | |||
| "url-loader": "^2.0.1", | |||
| "webpack": "^4.19.1", | |||
| "webpack": "^5.0.0-rc.6", | |||
There was a problem hiding this comment.
I always thought this would be a big upgrade, glad it wasn't too bad
There was a problem hiding this comment.
Yeah the disruption is pretty minor across the board, I'm happy to help if downstream projects hit an issue after this lands.
pringshia
added a commit
that referenced
this pull request
Jan 5, 2022
* Initial commit for docusaurus integration * Get storybook working with docusaurus, since they shared a common resolution for react-dev-utils * Add all docs to Docusaurus * Move pregenerated docs into Archive, fix up image links, fix up docusaurus.config.js * Fix webpack5 and react-dev-utils incompat error * Fix broken link in quickstart * Hide the blog for now and make some basic updates to the homepage * Fix docusaurus build issue * Documentation for the Mephisto Review CLI and front-end build work (#612) * Add review CLI docs * Add more content * Add Contributos & Authors folder * Docs reorg * Update broken link * fix sidebar * Position quickstart at the top of the Guides sidebar * Sidebar and footer updates * Flesh out sidebar organization a bit more * fix broken links * Adding tutorial stubs to docusaurus (#613) * Adding doc stubs * Contribution guide * Adding documentation stubs for many sections * Some documentation * Working through first tutorial using defaults * Fixing up mephisto wut * Finishing first tutorial finally :) * Fixing after webpack updates, work on tutorial 2 * Double ii fix * fix broken quickstart link * Almost finished with custom react tutorial * Unnecessary change Co-authored-by: Jack Urbanek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a number of pages intended to be filled out to complete my first pass of tutorial + how-to documentation.
High level categories: