-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cli for mephisto wut #820
Conversation
👈 Uncommented out code 🚧 Still have to create table for blueprint args
…nto improve-cli-for-mephisto-wut
Ok I really need to fix our deps to get |
Codecov Report
@@ Coverage Diff @@
## main #820 +/- ##
==========================================
+ Coverage 64.44% 64.60% +0.16%
==========================================
Files 107 107
Lines 9281 9281
==========================================
+ Hits 5981 5996 +15
+ Misses 3300 3285 -15
Continue to review full report at Codecov.
|
🤤 |
…nto improve-cli-for-mephisto-wut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. Excited to have the better mephisto wut
experience! Be sure to sync up the rich
versions across these PRs
mephisto/client/cli.py
Outdated
) | ||
return | ||
elif abstraction == "provider": | ||
# TODO: Use markdown list here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a plan for executing this TODO, or abandoning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already executed it, the print_out_valid_options method uses the markdown list.
I forgot to remove the TODO though.
Summary
Improved the cli of the
mephisto wut
command and general cli commands likemephisto
.It should be easier to see options for commands and errors should be more clear.
Tables should be much easier to read.
This is done with the rich-click and
rich
packages.The
rich-click
package gives rich formatting to cli commands.this replaces the default click object to get basic rich formatting.
The
rich
package is still needed for printing things to the console, such as tables.Video
mephisto-cli-improvement.mov