Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make self.metadata backward-compatible #861

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

chiehminwei
Copy link
Contributor

@chiehminwei chiehminwei commented Jul 25, 2022

This patch makes self.metadata in parlai_chat_agent_state backward-compatible by adding fallback options when the metadata field is not present in the state.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2022
@pringshia pringshia requested a review from JackUrb July 26, 2022 01:07
@Etesam913
Copy link
Contributor

You might want to run these three commands to make sure that the code that you added is formatted properly.
Screen Shot 2022-07-26 at 10 06 26 AM

This will make sure that your code passes the pre-commit / code-style (pull_request) test.

Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!

@JackUrb JackUrb merged commit 55f7937 into facebookresearch:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants