-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to customize html-static-task-example
submit button
#879
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
af07a50
✨ Added ability to customize html task submit button
Etesam913 feec532
🏗 Changed html crowd_source to use EventEmitter
Etesam913 5938013
🚛 Copied mock wrap_crowd_source changes into mturk
Etesam913 4eabea1
✏️ Improved naming & removed useless comment
Etesam913 5fc4412
🌐 Transpiled and minified eventEmitter
Etesam913 40a09f9
♻️ Refactored event use into useMephistoGlobalConfig
Etesam913 d65b46c
🔀 Merged with main
Etesam913 0d5086c
💡 Updated eventEmitter comments with links
Etesam913 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,11 +98,23 @@ function MainApp() { | |
|
||
function SubmitFrame({ children, onSubmit, currentTask }) { | ||
const [submitting, setSubmitting] = React.useState(false); | ||
const [isHidden, setIsHidden] = React.useState(false); | ||
|
||
const handler = React.useCallback( | ||
(hideValue) => { | ||
if (typeof hideValue == "boolean") setIsHidden(hideValue); | ||
}, | ||
[setIsHidden] | ||
); | ||
|
||
React.useEffect(() => { | ||
// Reset submitting when switching from onboarding | ||
setSubmitting(false); | ||
}, [currentTask]); | ||
}, []); | ||
|
||
React.useEffect(() => { | ||
window._MEPHISTO_CONFIG_.EVENT_EMITTER.on("HIDE_SUBMIT_BUTTON", handler); | ||
}, [setIsHidden]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Runs the hideSubmitButton handler method when the HIDE_SUBMIT_BUTTON event is emitted. |
||
|
||
function handleFormSubmit(event) { | ||
event.preventDefault(); | ||
|
@@ -121,13 +133,19 @@ function SubmitFrame({ children, onSubmit, currentTask }) { | |
{children} | ||
<div> | ||
<div style={{ display: "flex", justifyContent: "center" }}> | ||
<Button type="submit" disabled={submitting}> | ||
<span | ||
style={{ marginRight: 5 }} | ||
className="glyphicon glyphicon-ok" | ||
/> | ||
{submitting ? "Submitting..." : "Submit"} | ||
</Button> | ||
{!isHidden && ( | ||
<Button | ||
id="html-task-submit-button" | ||
type="submit" | ||
disabled={submitting} | ||
> | ||
<span | ||
style={{ marginRight: 5 }} | ||
className="glyphicon glyphicon-ok" | ||
/> | ||
{submitting ? "Submitting..." : "Submit"} | ||
</Button> | ||
)} | ||
</div> | ||
</div> | ||
</form> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was the rationale behind removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a mistake, I don't even know how that got updated.