Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gold units and functionality #923

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Adding gold units and functionality #923

merged 4 commits into from
Nov 8, 2022

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Nov 3, 2022

Overview

Based on the internal demo we ran today, I needed to make a few changes for gold units to work with our default setups out-of-box. This PR adds this, alongside a fix for unbounded gold launches (that we already had for validation).

Implementation

  • Screening and Validation units are both now part of StaticBlueprint and RemoteBlueprint. These are mutually exclusive and warn when trying to use both
  • Gold units now set max_gold_units, which is the maximum number to be launched for a specific job. This follows through to get_gold_unit_data_for_worker which will stop returning golds if they are no longer available, and should_produce_gold_for_worker which will no longer request golds for already-approved workers when golds are no longer available.

Testing

Automated tests
Running during the demo today

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Base: 64.26% // Head: 64.16% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (aeb1635) compared to base (66be164).
Patch coverage: 38.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
- Coverage   64.26%   64.16%   -0.11%     
==========================================
  Files         108      108              
  Lines        9405     9420      +15     
==========================================
  Hits         6044     6044              
- Misses       3361     3376      +15     
Impacted Files Coverage Δ
mephisto/operations/client_io_handler.py 83.85% <ø> (ø)
...to/abstractions/blueprints/mixins/use_gold_unit.py 29.55% <8.33%> (-1.74%) ⬇️
...lueprints/abstract/static_task/static_blueprint.py 42.10% <100.00%> (+0.61%) ⬆️
...ractions/blueprints/mixins/screen_task_required.py 74.74% <100.00%> (+0.25%) ⬆️
...nts/remote_procedure/remote_procedure_blueprint.py 43.29% <100.00%> (+0.59%) ⬆️
mephisto/abstractions/architects/mock_architect.py 88.23% <0.00%> (-2.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JackUrb JackUrb merged commit 367da31 into main Nov 8, 2022
@JackUrb JackUrb deleted the gold-upgrades branch November 8, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants