Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding citation note to readme #989

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Adding citation note to readme #989

merged 2 commits into from
Jan 13, 2023

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Jan 13, 2023

as titled

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 13, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 64.10% // Head: 64.06% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (8a511b7) compared to base (ec01e00).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   64.10%   64.06%   -0.05%     
==========================================
  Files         108      108              
  Lines        9445     9445              
==========================================
- Hits         6055     6051       -4     
- Misses       3390     3394       +4     
Impacted Files Coverage Δ
mephisto/abstractions/architects/mock_architect.py 88.23% <0.00%> (-2.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pringshia
Copy link
Contributor

LGTM. I had also created a duplicate PR #990 but closing that for this. Should we remove the empty newlines in the citation or is that a part of the format? Also in my PR I also just got rid of the Changelog section as that's been empty forever.

@JackUrb JackUrb merged commit 44f8b3d into main Jan 13, 2023
@JackUrb JackUrb deleted the readme-citation branch January 13, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants