Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename instrumentation to parametrization in optimizers init #497

Merged
merged 18 commits into from
Feb 5, 2020
Merged

Rename instrumentation to parametrization in optimizers init #497

merged 18 commits into from
Feb 5, 2020

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Feb 4, 2020 •
edited
Loading

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 4, 2020
@jrapin jrapin requested a review from teytaud February 4, 2020 17:28
@jrapin
Copy link
Contributor Author

jrapin commented Feb 4, 2020

@teytaud FYI this is a big change that will be breaking in v0.4.0: renaming instrumentation to parametrization as first parameter of the optimizers, for more clarity and consistency. In the meantime this PR introduces a "compatibility-mode" where you can still use instrumentation but get a deprecation warning. When it is landed I will release v0.3.2, and soon I will delete all old code and all compatibility-mode to release v0.4.0

@jrapin jrapin merged commit 9c8a694 into master Feb 5, 2020
@jrapin jrapin deleted the change_optimizer_init branch February 5, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teytaud teytaud Awaiting requested review from teytaud

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrapin @facebook-github-bot