Propagate configured optimizer #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jrapin
changed the title
jrapin
commented
Feb 18, 2020
| samplers = {"Halton": sequences.HaltonSampler, | ||
| "Hammersley": sequences.HammersleySampler, | ||
| "LHS": sequences.LHSSampler, | ||
| } | ||
| internal_budget = (budget + 1) // 2 if budget and (self._parameters == "quasi" or self._parameters == "opposite") else budget |
There was a problem hiding this comment.
@teytaud there was a bug there, since self._parameters is never quasi or opposite, it should have been self._parameters.opposition_mode.
I'll correct this in the next PR, I did not want to change all at once.
jrapin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
Propagates #518
How Has This Been Tested (if it applies)
Checklist