-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate configured optimizer #521
Conversation
samplers = {"Halton": sequences.HaltonSampler, | ||
"Hammersley": sequences.HammersleySampler, | ||
"LHS": sequences.LHSSampler, | ||
} | ||
internal_budget = (budget + 1) // 2 if budget and (self._parameters == "quasi" or self._parameters == "opposite") else budget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teytaud there was a bug there, since self._parameters
is never quasi
or opposite
, it should have been self._parameters.opposition_mode
.
I'll correct this in the next PR, I did not want to change all at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in #523
Types of changes
Motivation and Context / Related issue
Propagates #518
How Has This Been Tested (if it applies)
Checklist