Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather experimental variants together #528

Merged
merged 7 commits into from
Feb 25, 2020
Merged

Gather experimental variants together #528

merged 7 commits into from
Feb 25, 2020

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Feb 18, 2020

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

@teytaud the aim is to make the use of nevergrad simpler by only providing the main variantsof the optimizers.
All other optimizers can be created straightforwardly using the ng.families.DifferentialEvolution and other configurable classes.
On the other and, for the experiments, all variants are loaded

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 18, 2020
@teytaud teytaud self-requested a review February 19, 2020 08:23
Copy link
Contributor

@teytaud teytaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understand correctly, this is moving, not breaking, so imho just go ahead and we'll see in the long run if we fill that some algorithms should be moved elsewhere.

@jrapin
Copy link
Contributor Author

jrapin commented Feb 19, 2020

if I understand correctly, this is moving, not breaking, so imho just go ahead and we'll see in the long run if we fill that some algorithms should be moved elsewhere.

It's partially breaking: all the optimizers in experimentalvariants wont be available in ng.optimizers, and will only be registered in the optimizers registry if they explicitly import the module beforehand.
This is to avoid people getting lost with hundreds of variants and not knowing which one to use. Eventually we want to keep only the most important variants available, and promote the configured optimizers (with nice docstrings) so they can build the variants on their own that perfectly meet their needs

@jrapin jrapin changed the title [TO BE DISCUSSED] Gather experimental variants together Gather experimental variants together Feb 25, 2020
@jrapin jrapin merged commit b366e2b into master Feb 25, 2020
@jrapin jrapin deleted the xpvariants branch February 25, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants