Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep parameter in the archive #594

Merged
merged 5 commits into from
Mar 31, 2020
Merged

Keep parameter in the archive #594

merged 5 commits into from
Mar 31, 2020

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Mar 27, 2020

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Closes #290

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@jrapin jrapin self-assigned this Mar 27, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 27, 2020
@jrapin jrapin requested a review from teytaud March 27, 2020 16:39
@jrapin
Copy link
Contributor Author

jrapin commented Mar 27, 2020

@teytaud this will change a lot of things since now we can access the actual best candidate (not just their representation in R^n

@jrapin jrapin changed the title [WIP] Keep parameter in the archive Keep parameter in the archive Mar 28, 2020
@jrapin
Copy link
Contributor Author

jrapin commented Mar 31, 2020

discussed with @teytaud and accepted

@jrapin jrapin merged commit 2d5f716 into master Mar 31, 2020
@jrapin jrapin deleted the multival_param branch March 31, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teytaud teytaud Awaiting requested review from teytaud

Assignees

@jrapin jrapin

Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Difficulty: Medium Priority: High Type: Enhancement New feature or request Type: Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep args and kwargs in archive
2 participants
@jrapin @facebook-github-bot