Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename value to loss #774

Merged
merged 6 commits into from
Aug 4, 2020
Merged

Rename value to loss #774

merged 6 commits into from
Aug 4, 2020

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Jul 27, 2020 •
edited
Loading

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Consistency with Parameter, and better clarity to state that it's something we minimize

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@jrapin jrapin self-assigned this Jul 27, 2020
@jrapin
Copy link
Contributor Author

jrapin commented Jul 27, 2020

This clarification is the base for later work on multiobjective

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 27, 2020
@jrapin jrapin changed the title [WIP] Rename value to loss Rename value to loss Aug 4, 2020
@jrapin jrapin merged commit 5529528 into master Aug 4, 2020
@jrapin jrapin deleted the loss branch August 4, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrapin jrapin

Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Difficulty: Low Priority: Medium Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrapin @facebook-github-bot