Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add synced crosshairs #178

Merged
merged 46 commits into from
Sep 8, 2024
Merged

feat: Add synced crosshairs #178

merged 46 commits into from
Sep 8, 2024

Conversation

DaveSkender
Copy link
Member

@DaveSkender DaveSkender commented Jan 16, 2022

Fixes #141
Try again with new v2.0, may need to fork and update AbelHeinsbroek/chartjs-plugin-crosshair.

To do:

  • get sync groups working, so it spans across charts (see workaround)
  • refactor all typings stuff, it's a mess
  • legend params for placeholders not filled
  • add settings option to turn off (off by default)

this may require a Fork n' Fix of the plugin

  • internalize fixed variant of this plugin

@DaveSkender DaveSkender added the on hold Waiting for a dependency label Feb 16, 2022
@DaveSkender DaveSkender removed the on hold Waiting for a dependency label Aug 25, 2023
@DaveSkender DaveSkender changed the title add crosshairs feat: Add synced crosshairs Jan 7, 2024
Copy link

cloudflare-pages bot commented Feb 27, 2024

Deploying stock-charts with  Cloudflare Pages  Cloudflare Pages

Latest commit: 54eb904
Status: ✅  Deploy successful!
Preview URL: https://edf87f60.stock-charts.pages.dev
Branch Preview URL: https://crosshairs.stock-charts.pages.dev

View logs

@DaveSkender
Copy link
Member Author

Current situation is that the crosshairs work; however, they're no longer syncing across charts like they used to (before we had to remove with charts.js v4 incompatible upgrades).

image

@DaveSkender DaveSkender self-assigned this Aug 9, 2024
@DaveSkender
Copy link
Member Author

DaveSkender commented Sep 7, 2024

Had to take the code in and modify it to get it to work with newer chart.js versions and to sync; but it works. The sync across charts is a bit flakey if you move too fast. It also oddly doesn't reach the last bar.

  • consider removing entirely or replacing with a better custom option

image

@DaveSkender DaveSkender marked this pull request as ready for review September 8, 2024 22:09
@DaveSkender DaveSkender merged commit 6d1af34 into main Sep 8, 2024
8 of 9 checks passed
@DaveSkender DaveSkender deleted the crosshairs branch September 8, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add chartjs-plugin-crosshair after > v1.2.0 released with fixes
1 participant