Skip to content

Commit

Permalink
Fix: Use MkdirTemp instead of Mkdir to create a unique temp directory
Browse files Browse the repository at this point in the history
Signed-off-by: GLVS Kiriti <[email protected]>
  • Loading branch information
GLVSKiriti authored and poiana committed Apr 3, 2024
1 parent 44ce6f1 commit 5566085
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions events/syscall/read_shell_configuration_file.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package syscall

import (
"os"
"path/filepath"

"github.com/falcosecurity/event-generator/events"
)
Expand All @@ -26,15 +27,17 @@ var _ = events.Register(
)

func ReadShellConfigurationFile(h events.Helper) error {
const filename = "/created-by-event-generator/.bashrc"
if err := os.Mkdir("/created-by-event-generator", os.FileMode(0755)); err != nil {
// Create a unique tempdirectory
tempDirectoryName, err := os.MkdirTemp("/", "created-by-event-generator-")
if err != nil {
return err
}
if err := os.WriteFile(filename, nil, 0755); err != nil {
defer os.RemoveAll(tempDirectoryName)

filename := filepath.Join(tempDirectoryName, ".bashrc")
// os.Create is enough to trigger the rule
if _, err := os.Create(filename); err != nil {
return err
}
file, err := os.Open(filename)
defer file.Close()
defer os.RemoveAll("/created-by-event-generator")
return err
return nil
}

0 comments on commit 5566085

Please sign in to comment.