Skip to content

Commit

Permalink
feat(declarative): add support for declarative testing using YAML
Browse files Browse the repository at this point in the history
- Added a new subcommand declarative for run command
- Implemented parsing of YAML test files
- Added HostRunner for executing tests on the host
- Setup and Cleanup scripts execution
- Steps execution for write syscall
- Added detailed error handling and logging
- Ensure continuation of test even if one fails
- Added required helpers to test rule Write Below Root and Write Below Etc

Signed-off-by: GLVS Kiriti <[email protected]>
  • Loading branch information
GLVSKiriti authored and poiana committed Jun 18, 2024
1 parent 883cdf3 commit 5bd71c8
Show file tree
Hide file tree
Showing 8 changed files with 266 additions and 0 deletions.
17 changes: 17 additions & 0 deletions cmd/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,30 @@ package cmd

import (
"fmt"
"os"
"regexp"

"github.com/falcosecurity/client-go/pkg/client"
"github.com/falcosecurity/event-generator/events"
"github.com/falcosecurity/event-generator/pkg/declarative"
"github.com/spf13/pflag"
"gopkg.in/yaml.v2"
)

// This function parses the yaml file given and returns the tests data int it
func parseYamlFile(filepath string) (declarative.Tests, error) {
data, err := os.ReadFile(filepath)
if err != nil {
return declarative.Tests{}, fmt.Errorf("an error occurred while parsing file %s: %w", filepath, err)
}
var tests declarative.Tests
err = yaml.Unmarshal(data, &tests)
if err != nil {
return declarative.Tests{}, fmt.Errorf("an error occurred while unmarshalling yaml data: %w", err)
}
return tests, nil
}

func parseEventsArg(arg string) (map[string]events.Action, error) {
reg, err := regexp.Compile(arg)
if err != nil {
Expand Down
97 changes: 97 additions & 0 deletions cmd/declarative.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
// SPDX-License-Identifier: Apache-2.0
/*
Copyright (C) 2024 The Falco Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package cmd

import (
"fmt"

"github.com/falcosecurity/event-generator/pkg/declarative"
"github.com/spf13/cobra"
)

// NewDeclarative instantiates the declarative subcommand for run command.
func NewDeclarative() *cobra.Command {
c := &cobra.Command{
Use: "declarative [yaml-file-path]",
Short: "Execute Falco tests using a declarative approach",
Long: `This command takes the path to a YAML file as an argument.
The YAML file defines tests that are parsed and executed which
triggers specific Falco rules.`,
Args: cobra.MaximumNArgs(1),
DisableAutoGenTag: true,
}

c.RunE = func(c *cobra.Command, args []string) error {
tests, err := parseYamlFile(args[0])
if err != nil {
return err
}

var failedTests []error // stores the errors of failed tests

// Execute each test mentioned in yaml file
for _, eachTest := range tests.Tests {
err := runTestSteps(eachTest)
if err != nil {
// Collect the errors if any test fails
failedTests = append(failedTests, fmt.Errorf("test %v failed with err: %v", eachTest.Rule, err))
}
}

// Print all errors
if len(failedTests) > 0 {
for _, ft := range failedTests {
fmt.Println(ft)
}
return fmt.Errorf("some tests failed, see previous logs")
}

return nil
}

return c
}

// runTestSteps executes the steps, before and after scripts defined in the test.
func runTestSteps(test declarative.Test) error {
var runner declarative.Runner

// Assign a runner based on test.Runner value
switch test.Runner {
case "HostRunner":
runner = &declarative.Hostrunner{}
default:
return fmt.Errorf("unsupported runner: %v", test.Runner)
}

// Execute the "Before" script.
if err := runner.Setup(test.Before); err != nil {
return err
}

// Execute each step in the test.
for _, step := range test.Steps {
err := runner.ExecuteStep(step)
if err != nil {
return fmt.Errorf("error executing steps for the rule %v : %v", test.Rule, err)
}
}

// Execute the "After" script.
if err := runner.Cleanup(test.After); err != nil {
return err
}
return nil
}
1 change: 1 addition & 0 deletions cmd/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ func NewRun() *cobra.Command {
c.RunE = func(c *cobra.Command, args []string) error {
return runEWithOpts(c, args)
}
c.AddCommand(NewDeclarative())
return c
}

Expand Down
1 change: 1 addition & 0 deletions cmd/test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package cmd
import (

// register event collections

"time"

"github.com/falcosecurity/event-generator/pkg/runner"
Expand Down
21 changes: 21 additions & 0 deletions events/exampleyamlfile.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
tests:
- rule: WriteBelowRoot
runner: HostRunner
before: ""
steps:
- syscall: "write"
args:
filepath: "/root/created-by-event-generator"
content: ""
after: "rm -f /root/created-by-event-generator"

- rule: WriteBelowEtc
runner: HostRunner
before: ""
steps:
- syscall: "write"
args:
filepath: "/etc/created-by-event-generator"
content: ""
after: "rm -f /etc/created-by-event-generator"

37 changes: 37 additions & 0 deletions pkg/declarative/helpers.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// SPDX-License-Identifier: Apache-2.0
/*
Copyright (C) 2024 The Falco Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package declarative

import (
"fmt"

"golang.org/x/sys/unix"
)

func WriteSyscall(filepath string, content string) error {
// Open the file using unix.Open syscall
fd, err := unix.Open(filepath, unix.O_WRONLY|unix.O_CREAT, 0644)
if err != nil {
return fmt.Errorf("error opening file: %v", err)
}
defer unix.Close(fd)

// Write to the file using unix.Write
_, err = unix.Write(fd, []byte(content))
if err != nil {
return fmt.Errorf("error writing to file: %v", err)
}
return nil
}
59 changes: 59 additions & 0 deletions pkg/declarative/runner.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
// SPDX-License-Identifier: Apache-2.0
/*
Copyright (C) 2024 The Falco Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package declarative

import (
"fmt"
"os/exec"
)

// Common runner interface for runners like hostrunner, container-runner etc..
type Runner interface {
Setup(beforeScript string) error
ExecuteStep(step SyscallStep) error
Cleanup(afterScript string) error
}

type Hostrunner struct{}

func (r *Hostrunner) Setup(beforeScript string) error {
if beforeScript != "" {
if err := exec.Command("sh", "-c", beforeScript).Run(); err != nil {
return fmt.Errorf("error executing before script: %v", err)
}
}
return nil
}

func (r *Hostrunner) ExecuteStep(step SyscallStep) error {
switch step.Syscall {
case "write":
if err := WriteSyscall(step.Args["filepath"], step.Args["content"]); err != nil {
return fmt.Errorf("write syscall failed with error: %v", err)
}
default:
return fmt.Errorf("unsupported syscall: %s", step.Syscall)
}
return nil
}

func (r *Hostrunner) Cleanup(afterScript string) error {
if afterScript != "" {
if err := exec.Command("sh", "-c", afterScript).Run(); err != nil {
return fmt.Errorf("error executing after script: %v", err)
}
}
return nil
}
33 changes: 33 additions & 0 deletions pkg/declarative/yamltypes.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// SPDX-License-Identifier: Apache-2.0
/*
Copyright (C) 2024 The Falco Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package declarative

// Yaml file structure
type SyscallStep struct {
Syscall string `yaml:"syscall"`
Args map[string]string `yaml:"args"`
}

type Test struct {
Rule string `yaml:"rule"`
Runner string `yaml:"runner"`
Before string `yaml:"before"`
Steps []SyscallStep `yaml:"steps"`
After string `yaml:"after"`
}

type Tests struct {
Tests []Test `yaml:"tests"`
}

0 comments on commit 5bd71c8

Please sign in to comment.